Friday, May 24, 2019

Questions about colors/tools/check_colors.vim

Currently, colors/tools/check_colors.vim prints warnings when

1. one of the checked highlight groups is defined with `hi link` instead of `hi`;
2. a hi command defines guifg but not ctermfg or vice versa.

For instance, I get warnings for

hi! link ColorColumn SomethingElse

Is this intended, i.e., is that to be taken as a recommendation not to link those groups?

I also get warnings for something like:

if (has('termguicolors') && &termguicolors) || has('gui_running')
" Define only GUI colors
hi DiffAdd guifg=#abb96e guibg=#5f5f61 guisp=NONE gui=reverse cterm=reverse
" …
else
" Define only terminal colors
hi DiffAdd ctermfg=143 ctermbg=59 cterm=reverse
endif

In this case, I think that the script is too strict and the check at lines 48-50 should be removed.

Finally, I'd like to send a patch for that script: where should I send it?

Thanks,
Life.



--
--
You received this message from the "vim_use" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

---
You received this message because you are subscribed to the Google Groups "vim_use" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vim_use+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/vim_use/DEBD31C5-4D30-48BA-9EC1-3AFA49126A86%40icloud.com.
For more options, visit https://groups.google.com/d/optout.

No comments:

Post a Comment