Re: Problem with signcolum=number

Hi,

On Mon, Jul 1, 2019 at 11:56 AM Bram Moolenaar <Bram@moolenaar.net> wrote:
>
> Yegappan wrote:
>
> > On Mon, Jul 1, 2019 at 7:57 AM Salman Halim <salmanhalim@gmail.com> wrote:
> > >>
> > >> On Mon, Jul 1, 2019 at 7:09 AM Salman Halim <salmanhalim@gmail.com> wrote:
> > >> >
> > >> > Hello,
> > >> >
> > >> > When setting 'signcolumn' to number, if I edit a file containing fewer
> > >> > than ten lines and have a plug-in that shows marks as signs (or have
> > >> > manually created signs), the signs are occasionally three columns
> > >> > wide, thus wider than the number column. This breaks editing, such as
> > >> > pressing x to remove a character (it removes the wrong character).
> > >> >
> > >>
> > >> Can you post the sign definition? When you say "occasionally", do you
> > >> know which operation or movement triggers this?
> > >>
> > >> Thanks,
> > >> Yegappan
> > >
> > >
> > > It's a trivial case.
> > > Start with an empty file: gvim -u NONE -U NONE
> > > (I use Windows, gvim 8.1-1608)
> > >
> > > :set number numberwidth=1 signcolumn=number
> > >
> >
> > As the sign text takes two columns, the minimum supported value for
> > 'numberwidth' is 3 with 'signcolumn' set to 'number'.
> >
> > When 'signcolumn' is set to 'number', I think we should change the value
> > of 'numberwidth' to a minimum of 3 (if it is less than 3)?
>
> Yes, can be added to number_width().
> Would appreciate if you add a test.
>

I created PR #4606 with a fix for this issue and the tests for it.

https://github.com/vim/vim/pull/4606

- Yegappan

--
--
You received this message from the "vim_use" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

---
You received this message because you are subscribed to the Google Groups "vim_use" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vim_use+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/vim_use/CAAW7x7%3DtRVWbQuyd-O54Ah3WEcbXt6Fhf9fV37JBk-KnJtJE4A%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.