Sunday, April 5, 2020

Re: Theme dev (Selenized) help: SpellRare and undercurl not working in Vim, works in NeoVim

I see that this patch was meant to make undercurl work in
terminals that support it:

===
commit 8b9e20afb0da79a21155988a38704b5777cc2efe
Author: Bram Moolenaar <Bram@vim.org>
Date: Tue Nov 28 21:25:21 2017 +0100

patch 8.0.1358: undercurl is not used in the terminal

Problem: Undercurl is not used in the terminal. (Kovid Goyal)
Solution: Only fall back to underline when undercurl highlighting is not
defined. (closes #1306)
===

But somehow it does not work: I see neither undercurl nor underline
when using vim >= 8.0.1358 in various terminals.

There was no tests added to verify 8.0.1358.

If I go back to vim-8.0.1357, then I could see at least underline being
used in the terminal where undercurl is specified.
I tried with xterm (330), xfce4-terminal 0.8.7.4 and gnome-terminal 3.28.2
and all used underlines prior with vim < 8.0.1357 as fallback to undercurl.

So patch 8.0.1358 introduced a regression.

Regards
Dominique

--
--
You received this message from the "vim_use" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

---
You received this message because you are subscribed to the Google Groups "vim_use" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vim_use+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/vim_use/CAON-T_hsx4cvFjt_GonyC5mzTRJ7x69AtOPkM-PeaudSnVmJhg%40mail.gmail.com.

No comments: