Saturday, July 9, 2011

Re: VCSCommand - push/pull

On 07/09/2011 04:10 AM, eleanor wrote:
> " Push the current working directory to repository
> "
> function RepoPush()
> :! git push origin master
> endfunction
>
> Tell me what do you think about the solution. Do you see any errors ...
> anything that could be better?

Two things stand out to me:

1) the ":" is optional/superfluous in a function so that (and the
other "!" commands) can just be written as

! git push origin master


2) from my admittedly minimal working experience of git, I
believe this "push" hard-codes the branch to which you're pushing
("master") which makes it hard if you want to commit/push an
alternate branch. This may be "good enough" for your purposes,
but for something to share, I'd try to make that more open-ended.

-tim


--
You received this message from the "vim_use" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

No comments: